Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reject graphsync unpaid retrievals when unseal price is non-zero #1287

Closed
hannahhoward opened this issue Mar 16, 2023 · 0 comments · Fixed by #1289
Closed

Don't reject graphsync unpaid retrievals when unseal price is non-zero #1287

hannahhoward opened this issue Mar 16, 2023 · 0 comments · Fixed by #1289

Comments

@hannahhoward
Copy link
Collaborator

What

When a free retrieval is proposed, it's intercepted by the faster unpaid graphsync retrieval pipeline. This pipeline will fail unless the deal is already unsealed, so no unsealing ever occurs. However, if the SP set an unseal price, the deal will still get rejected here --

if !ask.UnsealPrice.IsZero() || !ask.PricePerByte.IsZero() {

This forces to SP to set UnsealPrice of zero to serve any free retrievals.

I think this check should probably drop the check on UnsealPrice. Under normal conditions in go-fil-markets, GetAsk is a more complicated call that will set Ask parameters based on the sector being unsealed (and will always set the unseal price to zero), so this is equavalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant