You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add --debug-log flags to lotus state compute-state, lotus state exec-trace, lotus state replay, and lotus state call.
Remove the LOTUS_FVM_DEVELOPER_DEBUG environment variable.
When these flags are specified, we should run the FVM in dual-execution mode as we currently do when LOTUS_FVM_DEVELOPER_DEBUG. Additionally, now that the actor logs have been moved into the trace, we can return the actor logs as a part of the command output instead of writing them to stdout.
However, there are two wrinkles we need to tackle before someone can take this:
Dual execution doubles the execution cost, so we only want to do this when requested by the user. Unfortunately, we don't have a great way to tell commands like StateCompute about this. We'll need to consider how we want to pass information like this over the RPC API.
We still want accurate gas traces we'll end up with two traces: one with accurate gas usage and one with debug logs. Ideally we'd merge them and copy all the debug logs from the "debug" trace into the "real" trace. However, the debug trace can go off and do completely different things (it generally shouldn't, but it might in a few cases) so we'll need to be careful about how we write the merge algorithm.
Specifically:
--debug-log
flags tolotus state compute-state
,lotus state exec-trace
,lotus state replay
, andlotus state call
.LOTUS_FVM_DEVELOPER_DEBUG
environment variable.When these flags are specified, we should run the FVM in dual-execution mode as we currently do when
LOTUS_FVM_DEVELOPER_DEBUG
. Additionally, now that the actor logs have been moved into the trace, we can return the actor logs as a part of the command output instead of writing them to stdout.However, there are two wrinkles we need to tackle before someone can take this:
StateCompute
about this. We'll need to consider how we want to pass information like this over the RPC API.Depends on filecoin-project/filecoin-ffi#510.
The text was updated successfully, but these errors were encountered: