Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random test failure, syncing beyond genesis #4317

Closed
Kubuxu opened this issue Oct 11, 2020 · 6 comments · Fixed by #4559
Closed

Random test failure, syncing beyond genesis #4317

Kubuxu opened this issue Oct 11, 2020 · 6 comments · Fixed by #4559
Labels
impact/test-flakiness Impact: Test Flakiness kind/test Kind: Test

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Oct 11, 2020

    sync_test.go:172: 
        	Error Trace:	sync_test.go:172
        	            				sync_test.go:130
        	            				sync_test.go:506
        	            				sync_test.go:800
        	Error:      	Received unexpected error:
        	            	sync to submitted block failed:
        	            	    github.com/filecoin-project/lotus/node/impl/full.(*SyncAPI).SyncSubmitBlock
        	            	        /home/circleci/project/node/impl/full/sync.go:89
        	            	  - collectChain failed:
        	            	    github.com/filecoin-project/lotus/chain.(*Syncer).Sync
        	            	        /home/circleci/project/chain/sync.go:580
        	            	  - failed to load next local tipset:
        	            	    github.com/filecoin-project/lotus/chain.(*Syncer).collectHeaders
        	            	        /home/circleci/project/chain/sync.go:1395
        	            	  - get block bafyreiaqpwbbyjo4a42saasj36kkrpv4tsherf2e7bvezkert2a7dhonoi:
        	            	    github.com/filecoin-project/lotus/chain/store.(*ChainStore).LoadTipSet.func1
        	            	        /home/circleci/project/chain/store/store.go:548
        	            	  - cbor input should be of type array
        	Test:       	TestSyncCheckpointEarlierThanHead
@Kubuxu Kubuxu added kind/test Kind: Test impact/test-flakiness Impact: Test Flakiness labels Oct 11, 2020
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 12, 2020

Similar error in pledge sector:

failed to submit newly mined block: sync to submitted block failed: collectChain failed: failed to load next local tipset: get block bafyreiaqpwbbyjo4a42saasj36kkrpv4tsherf2e7bvezkert2a7dhonoi: cbor input should be of type array
    util.go:73: block never managed to sync to node

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 23, 2020

Similar error in TestAPI/id:

miner	miner/miner.go:283	failed to submit newly mined block: sync to submitted block failed: collectChain failed: failed to load next local tipset: get block bafyreiaqpwbbyjo4a42saasj36kkrpv4tsherf2e7bvezkert2a7dhonoi: cbor input should be of type array
    util.go:73: block never managed to sync to node

@Kubuxu Kubuxu changed the title Test failure in TestSyncCheckpointEarlierThanHead Random test failure, syncing beyond genesis Oct 23, 2020
@dirkmc
Copy link
Contributor

dirkmc commented Oct 23, 2020

I'm seeing these errors in tests all over the place

@dirkmc
Copy link
Contributor

dirkmc commented Oct 23, 2020

submitted block failed: collectChain failed: failed to load next local tipset: get block bafyreiaqpwbbyjo4a42saasj36kkrpv4tsherf2e7bvezkert2a7dhonoi: cbor input should be of type array

https://app.circleci.com/pipelines/github/filecoin-project/lotus/10964/workflows/8dbcec09-1c0e-4fd7-b7e1-7d4d3a69a532/jobs/81698

@schomatis schomatis self-assigned this Oct 23, 2020
@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 23, 2020

Reproduction: go test -v -run TestAPI/id -count 100 -failfast ./node

@schomatis schomatis removed their assignment Oct 23, 2020
@schomatis
Copy link
Contributor

Fixed by @Kubuxu, we're ignoring the possibility of null blocks in the sync logic and may request more than needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/test-flakiness Impact: Test Flakiness kind/test Kind: Test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants