-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion proofs, error instead of panic #1609
Comments
this problem may be related to special
|
That's true. Not sure if it does relate to merkletree crate... It looks like implementation of Can't it be resolved by adding information about sector into calling code where panic is invoked? I mean in such case we need to change caller that use Poseidon hasher by adding something like that:
and of course, Rust logging should be enabled, as it looks like it is invoked from Go high-level code. |
If |
Description
Currently if we read in invalid data there is a panic:
rust-fil-proofs/filecoin-hashers/src/poseidon.rs
Line 345 in ccfea67
If an error would be returned (instead of a panic), one could then catch that error here
rust-fil-proofs/storage-proofs-post/src/fallback/vanilla.rs
Line 638 in ccfea67
Acceptance criteria
The sector ID is somehow displayed if there is invalid data.
Risks + pitfalls
This also needs changes in the
merkletree
crate and I'm not sure how big the overall changes will be. So it might not be worth it.Where to begin
Make
rust-fil-proofs/filecoin-hashers/src/poseidon.rs
Lines 335 to 354 in ccfea67
Result
s instead of panicking and see which other changes are needed due to this.The text was updated successfully, but these errors were encountered: