Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zigzag example #500

Closed
2 of 6 tasks
porcuquine opened this issue Feb 22, 2019 · 1 comment · Fixed by #513
Closed
2 of 6 tasks

Improve zigzag example #500

porcuquine opened this issue Feb 22, 2019 · 1 comment · Fixed by #513
Assignees

Comments

@porcuquine
Copy link
Collaborator

porcuquine commented Feb 22, 2019

Description

The zigzag example needs some improvements as part of a push to reconcile security and scaling requirements.

Non-exhaustively:

  • Support tapered challenges
  • Use less memory so larger parameters can be generated
  • Log individual partition proof timing
  • Update defaults
  • Don't hold onto data during proof generation. Current implementation does so in case of extraction, but we don't really use that. Consider removing.
  • Don't duplicate vanilla proving (it's included in CompoundProof generation). If we had a better way of gather granular timing/profiling of internal parts, we could use that. We should. Meanwhile, now that vanilla proving is fast, it's not a huge deal — but for correctness it should not be added to total proving time.

Acceptance criteria

Risks + pitfalls

Where to begin

@dignifiedquire
Copy link
Contributor

Zigzag examples is moving into filbase, closing this issue for now. Will track new requirements there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants