-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use MmapStore
for MerkleTree
generation
#529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
requested review from
dignifiedquire,
laser and
porcuquine
as code owners
March 7, 2019 17:05
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 8, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
schomatis
force-pushed
the
feat/dgraph/use-mmap-merkle
branch
from
March 14, 2019 21:02
96ccc64
to
bcb9634
Compare
schomatis
changed the title
[WIP]
use Mar 14, 2019
dgraph::Graph
: use MmapStore
for MerkleTree
generationMmapStore
for MerkleTree
generation
This comment has been minimized.
This comment has been minimized.
schomatis
force-pushed
the
feat/dgraph/use-mmap-merkle
branch
2 times, most recently
from
March 15, 2019 15:09
f19a16f
to
26833f0
Compare
schomatis
force-pushed
the
feat/dgraph/use-mmap-merkle
branch
2 times, most recently
from
March 21, 2019 15:15
da14888
to
21124c9
Compare
porcuquine
previously approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine when the rest is sorted out (might be already).
schomatis
force-pushed
the
feat/dgraph/use-mmap-merkle
branch
from
March 22, 2019 00:39
21124c9
to
5d3ec83
Compare
porcuquine
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on filecoin-project/merkletree#13, after that is merged the dependency here should point tomerkle_light/master
.This is now dropping the allocated memory an order of magnitude: