Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the ZigZag parent's cache in advance for both forward and backward directions. #550

Closed
schomatis opened this issue Mar 13, 2019 · 2 comments

Comments

@schomatis
Copy link
Contributor

// TODO: Optimization: Evaluate providing an `all_parents` (and hence
// `all_expanded_parents`) method that would return the entire cache
// in a single lock operation, or at least (if the cache is not big enough)
// it would allow to batch parents calculations with that single lock. Also,
// since there is a reciprocity between forward and reversed parents,
// we would only need to compute the parents in one direction and with
// that fill both caches.

@schomatis schomatis added the perf label Mar 13, 2019
@schomatis
Copy link
Contributor Author

(Bumping it to 3, this needs some more discussion about the design before it can be implemented.)

@dignifiedquire
Copy link
Contributor

no more zigzag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants