feat: switch to the latest pairing #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dignifiedquire
commented
Mar 20, 2019
•
dignifiedquire
commented
- use fork filecoin-project/bellman
- use fork filecoin-project/phase2
- use fork filecoin-project/sapling-crypto
- use fork filecoin-project/pairing
|
Unfortunately the perf improvements did not translate to replication. |
porcuquine
reviewed
Mar 21, 2019
|
yes, because we can more easily tweak bellman and we will need to do that and it does make operations more efficient, juznit faster in the grand overall scheme
…On 21. Mar 2019, 23:22 +0100, porcuquine ***@***.***>, wrote:
@porcuquine commented on this pull request.
Since this didn't have the intended effect, do you still want to move forward with this now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
porcuquine
previously approved these changes
Mar 22, 2019
- use fork filecoin-project/bellman - use fork filecoin-project/phase2 - use fork filecoin-project/sapling-crypto -use zkcrypto/pairing
dignifiedquire
force-pushed
the
update-bellman-pairing
branch
from
9d53223
to
8b71a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.