Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on including a starting block height in a deal proposal #200

Closed
ZenGround0 opened this issue Mar 19, 2019 · 4 comments
Closed

Decide on including a starting block height in a deal proposal #200

ZenGround0 opened this issue Mar 19, 2019 · 4 comments

Comments

@ZenGround0
Copy link
Contributor

ZenGround0 commented Mar 19, 2019

Ripping this text directly from a TODO in network-protocols.md

Possibly also include a starting block height here [the deal proposal], to indicate when this deal may be started (implying you could select a value in the future). After the first response, both parties will have signed agreeing that the deal started at that point. This could possibly be used to challenge either party in the event of a stall. This starting block height also gives the miner time to seal and post the commitment on chain. Otherwise a weird condition exists where a client could immediately slash a miner for not having their data stored.

Filing this issue to track all work needed to close out this TODO, either by deciding to drop this idea and remove the TODO, or write up this idea and officially get it into the spec.

@mhammersley
Copy link

@nicola , is this faults related?

@mhammersley
Copy link

also @sternhenri for awareness

@sternhenri
Copy link
Contributor

I think @whyrusleeping is decider here. What's the current consensus here, do we still believe this is necessary @whyrusleeping ? If so, can you spec it real quick and merge? Also happy to do it if you can discuss for 5 mins.

@mishmosh
Copy link
Contributor

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants