Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care to separate abstract concepts and their concrete definitions #44

Closed
whyrusleeping opened this issue Nov 10, 2018 · 2 comments
Closed
Assignees

Comments

@whyrusleeping
Copy link
Member

In general, we should take care to not conflate abstract concepts (PoRep, EC, State Machine) with the concrete implementations. For example, Expected consensus doesnt necessarily care about storage power, or proofs of spacetime. That is (for lack of a better name) 'Filecoin Consensus'.

Another more actionable example is that we should find a name for our specific implementation of each proof. It is not exactly correct to say that "Proof of Replication ... produces a SNARK proof". Proof of replication simply proves in some way that a unique replica of some input data has been created. The description at the top of the proofs.md spec file does this well, it's just later in the doc where we give a concrete definition that we should phrase it differently. One simple proposal would be to just call this SNARK construction "PoRep-1" and say that "PoRep-1 ... produces a SNARK proof" (and so on). Obviously someone with a knack for naming could pick something better than a numeric naming system.

cc @porcuquine @nicola

@nicola
Copy link
Contributor

nicola commented Nov 12, 2018

ACK

@porcuquine porcuquine self-assigned this Nov 13, 2018
@pooja pooja transferred this issue from another repository Jan 11, 2019
@pooja
Copy link
Contributor

pooja commented Apr 5, 2019

A general note, which participants have ack'ed

@pooja pooja closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants