-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write spec for 'hello' protocol #1252
Labels
P1
High - we should be working on this now or in the immediate future
Comments
whyrusleeping
added
the
P1
High - we should be working on this now or in the immediate future
label
Oct 30, 2018
cc @ZenGround0 |
@ZenGround0 any progress here? |
@whyrusleeping Why is this an issue in filecoin-project/go-filecoin and not filecoin-project/specs? |
@acruikshank so that devs will see the issues. @phritz and I discussed this and decided it would be easiest to have these issues here so they aren't hidden away in a repo that most devs never look at. |
20 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We need to document the 'hello' protocol in the spec. This should go in the 'network-protocols.md' document for now, and be sufficient for someone to implement the protocol fully.
Where to begin
Pull down the latest specs here: https://github.com/filecoin-project/specs and add the changes to the bottom of the 'network-protocols.md' document.
Try to follow the format that the other protocols documented there follow, but if you feel like improving on the model, please do (and make a note of the divergence in the PR, then i'll adjust the other docs to match).
Submit your changes as a PR to the specs repo, and we will move forward from there
The text was updated successfully, but these errors were encountered: