Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement BLS signatures #1566

Closed
phritz opened this issue Jan 4, 2019 · 1 comment
Closed

implement BLS signatures #1566

phritz opened this issue Jan 4, 2019 · 1 comment
Assignees

Comments

@phritz
Copy link
Contributor

phritz commented Jan 4, 2019

Placeholder for actual work.

Additional acceptance criteria:

  • maybe close out Signature code and tests should be in one, reasonable place. #1326?
  • new code has unit tests
  • no new shortcuts taken in tests -- tests work at least as "real" as they do today unless we agree otherwise
  • talk to go-filecoin team about what this change means before it is implemented in order to get feedback, eg at dev-wide meeting, in an issue, or at storytime; also consider an implementation plan sketch to reduce risk
  • frrist timeboxed to <=20% of his time on average (can be more during ramp up)
  • this work is done done when this issue is closed out, meaning zero technical debt deferred, follow-up issues, TODOs for missing features that could be implemented today, tests, places in the code where we should be using it but aren't, etc. ; see "do not create technical debt" section of https://github.com/filecoin-project/go-filecoin/blob/master/CONTRIBUTING.md#developer-dos-and-donts
@frrist
Copy link
Member

frrist commented Jan 15, 2019

closing in favor of #1606, I have moved this issue description to the epic.

@frrist frrist closed this as completed Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants