Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose EnableGasTracing as an env_var setting #4610

Closed
Fatman13 opened this issue Dec 13, 2021 · 0 comments · Fixed by #4653
Closed

Expose EnableGasTracing as an env_var setting #4610

Fatman13 opened this issue Dec 13, 2021 · 0 comments · Fixed by #4653
Labels
good first issue Call for participation: Well-suited to new project contributors help wanted Call for participation: More complex than good-first-issue V-venus-sealer venus-sealer component

Comments

@Fatman13
Copy link
Contributor

Reference: filecoin-project/lotus#7648

EnableGasTracing is super helpful for understanding gas cost analysis, users should be able to get that information for compute state if they want without updating the code. expose this variable as an envvar that user can set, default to be false.
@Fatman13 Fatman13 added help wanted Call for participation: More complex than good-first-issue good first issue Call for participation: Well-suited to new project contributors V-venus-sealer venus-sealer component labels Dec 13, 2021
@tanqiangyes tanqiangyes mentioned this issue Dec 28, 2021
Merged
@Fatman13 Fatman13 linked a pull request Dec 28, 2021 that will close this issue
use env var to enable gas tracing #4653
Merged
@Fatman13 Fatman13 mentioned this issue Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Call for participation: Well-suited to new project contributors help wanted Call for participation: More complex than good-first-issue V-venus-sealer venus-sealer component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use env var to enable gas tracing tanqiangyes/venus
1 participant
@Fatman13