Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT e2e test failure #41

Open
h657070128 opened this issue Jul 21, 2017 · 6 comments · May be fixed by #76
Open

AOT e2e test failure #41

h657070128 opened this issue Jul 21, 2017 · 6 comments · May be fixed by #76

Comments

@h657070128
Copy link

Hi, sorry for bothering again.
I cloned the project and did not make any changes. After I run npm install, I am trying to run npm run integration to do an e2e test.
But it failed. I looked into it and found bundle.js under integration/dist is not generated.
Why?
I found there is a warning during rollup:

(node:34922) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: 'Subject' is not exported by ../node_modules/rxjs/Subject.js
(node:34922) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I am not sure if it's preventing the code being packaged.
I am wondering are you guys using this seed can run it successfully?

@FriOne
Copy link

FriOne commented Aug 18, 2017

@h657070128 I commented this include: ['node_modules/rxjs/**'], line in integration/build.js and this solved the problem.

@playground
Copy link

playground commented Aug 24, 2017

I have a similar issue. I cloned the project, ran npm install then npm run integration.

npm ERR! code ENOLOCAL
npm ERR! Could not install from "../dist" as it does not contain a package.json file.

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/tester/.npm/_logs/2017-08-24T23_07_42_959Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! quickstart-lib@1.0.0 preintegration: npm run build && cd integration && npm run clean && npm install
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the quickstart-lib@1.0.0 preintegration script.

@mmmichl
Copy link

mmmichl commented Sep 4, 2017

to resolve the aot build issue, downgrade in integration/package.json following package:

    "rollup-plugin-node-resolve": "2.0.0",

rollup/rollup-plugin-node-resolve#94
theatersoft/client@2202137

regarding the "../dist" issue:

I think npm introduced in some recent version to symlink locally installed packages. This is the issue here. What I did in integration/package.json, I changed the clean target to following:

    "clean": "rimraf aot/ dist/",

Note: this works on current versions of npm, but might break the clean up on older versions.

@muhammedgaygisiz
Copy link

@mmmichl downgrading rollup-plugin-node-resolve worked for me. I checked also the bundle.js under integration and it is generated. So maybe it is the only necessary point to fix the issue?

@muhammedgaygisiz muhammedgaygisiz linked a pull request May 13, 2020 that will close this issue
@mmmichl
Copy link

mmmichl commented May 14, 2020

Thank for your response, but in the meantime I switched to the angular CLI for lib development.

@muhammedgaygisiz
Copy link

Ok, i was thinking about switching to this seed project from angular cli lib devevelopment :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants