Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Buttons dissapear if you remove them. #288

Closed
mrd77 opened this issue Feb 6, 2023 · 2 comments
Closed

Addon Buttons dissapear if you remove them. #288

mrd77 opened this issue Feb 6, 2023 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@mrd77
Copy link

mrd77 commented Feb 6, 2023

Description

Add-on Buttons disappear completely without the possibility to re-add them from the "Customize Toolbar..." window after removing from toolbar (and restarting PWA)

Steps to Reproduce

  1. Create new Firefox PWA
  2. Install Add-on with dedicated button. Button gets added beside tab-bar. You can pin it to overflow menu, or move it in via the "Customize Toolbar" window
  3. You can also delete the button and re-add, until you restart the PWA (close all windows and reopen, without necesarly restarting firefox itself). Then the button dissapears from the customize menu without the possibility to re-add.

before and after restart
"ublock Origin" is gone in the after picture

Environment

  • Operating system: Windows 10
  • System architecture: 64 bit
  • PWAsForFirefox extension version: 2.4.0
  • PWAsForFirefox native version: 2.4.0
  • Firefox version: 109.0.1
@mrd77 mrd77 added the bug Something isn't working label Feb 6, 2023
@mrd77
Copy link
Author

mrd77 commented Feb 6, 2023

my guess is this has something to do with the newly introduced add-on button on main firefox?

@mrd77 mrd77 closed this as completed Feb 6, 2023
@mrd77 mrd77 reopened this Feb 6, 2023
@filips123
Copy link
Owner

Yes, it is related to the new unified extensions button. I thought I've disabled it until I add proper support, but it seems I did that too later in the code. I will soon release a new version that properly enables unified extensions.

@filips123 filips123 added this to the 2.4.1 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants