Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation for start_url #530

Closed
ccoager opened this issue Aug 7, 2024 · 2 comments
Closed

Remove validation for start_url #530

ccoager opened this issue Aug 7, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ccoager
Copy link

ccoager commented Aug 7, 2024

Problem Description

I understand there are issues and limitations with Firefox containers/Multi-Account Containers impacting PWA. I have found a work around using the Open external links in a container add-on. This will launch the PWA directly into the container of your choice. The only issue is the PWA start_url validation prevents you from using the syntax needed for this add-on and gives the error, "Start URL needs to be a valid URL".

I have tested this work around by editing the PWA config.json directly and can confirm that it does work.

Proposed Solution

Could you remove the validation for start_url?

@ccoager ccoager added the enhancement New feature or request label Aug 7, 2024
@filips123
Copy link
Owner

I can try to turn it into warning or someting similar. But I'm not sure if it will work properly, as I think there is also some validation in the manifest that requires start URL to be in the scope.

@filips123 filips123 added this to the 2.12.2 milestone Aug 13, 2024
@filips123 filips123 modified the milestones: 2.12.2, 2.12.3 Sep 7, 2024
@filips123 filips123 modified the milestones: 2.12.4, 2.12.5 Sep 15, 2024
@filips123
Copy link
Owner

I turned start URL validation into a warning in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants