-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some CI fixes #193
base: main
Are you sure you want to change the base?
Add some CI fixes #193
Conversation
6796e8c
to
be4ef10
Compare
dfa434b
to
355e55e
Compare
4780c36
to
a3b3a5a
Compare
Now that 6.1 branched, I had the CI build the first Android SDK bundle from the first tag from that branch today. It passed all CI testing, but if you want to test it with other packages of your own, @marcprux, try it out. You will probably have to pass SwiftPM the additional flags |
7f2bdb8
to
f1c09cd
Compare
b46b1e2
to
f8d4e8a
Compare
I want to look into consolidating the number of jobs next, way too many right now. |
d5af195
to
706a0ba
Compare
@marcprux, let me know what you think of this consolidation of CI jobs, which allows me to package the SDK bundle much earlier and eliminate a bunch of logic. There is some new repitition because |
I had been looking over it earlier, and I like it. I think building the sample repositories using the post-packaged and installed SDK is a great idea, and I doubt we will see it take much longer from the lack of parallelization. Personally, I think that we might also want to ditch the macOS jobs altogether. We're a long way from getting the SDK to actually build on macOS (I've given up trying to work around all the Darwin assumptions in the build scripts), so the current behavior of just downloading the cached Linux build isn't all that useful (and requires re-running the failed CI job every time there's a new Swift nightly release so macOS can find the Linux-cached build). Not testing on macOS would be a bit of a loss, but I done recall ever seeing test fail on the macOS Android emulator that otherwise passed on Linux Android emulator, so I don't see any loss of coverage there. Such a change doesn't need to necessarily be done as part of this PR, but it would contribute towards the simplification and speeding up of the process. |
I agree that the macOS jobs don't currently add much, but I like having them double-check that the SDK bundles built on linux are working well to cross-compile packages. I plan to look into building the SDK bundles also on macOS in the coming months. |
Sounds good. An alternative solution could be to break it up into two separate jobs, a |
4915b4b
to
ab82f2d
Compare
I thought about keeping a seventh initial job, simply to download and cache the toolchains and turn off the mac jobs if a new snapshot is tagged, as done now. I'd rather just restart the mac jobs instead, at least until I get them building SDK bundles too. |
No description provided.