-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace console.log with structured logging #399
Comments
@coopernetes - good idea. We already have the basis of Good idea! 👍 |
Taking a look at this over the next few days 😊 |
@LMBroadhurst - if you're interested, next Monday (and every 2 weeks) we have 1 hour meeting with all Git Proxy maintainers; if you'd like to show up and get to know each other, please email help@finos.org and I'll take it from there. Thanks for your help! |
@LMBroadhurst - awesome! 👍 I've assigned the ticket to you. |
Thanks @maoo would love to join. will send an email through. |
Hey, @LMBroadhurst I was wondering if you would like some assistance with this issue? |
@LMBroadhurst - I can see you've made progress on your fork and branch. Awesome 🙌 What is outstanding? |
@abinash2512 @JamieSlome Hey guys, sorry caught a nasty bug and was wiped out the last two weeks. I'm pretty sure the code is in place and ready to go, I just wanted to test it out by using git-proxy and was struggling a bit with it. Going to give it another go this evening to make sure the logging is working as expected. Also was wondering, would it be useful to actually keep the console.log code, in addition to new logging? |
@LMBroadhurst - hope you are feeling better now - sorry to hear 😢 Let us know if you need any support in testing it; I'm generally always available ❤️ You can ping me here or on the Slack channel! |
@JamieSlome Much better now thanks 😄. I tried to join the slack channel from the links on the repo but seems you need certain permissions to access the channels. Could you please email me an invite/add me to the slack via my email lewis1broadhurst@gmail.com? |
Just invited you to Slack! Ping me when you're in, so I can add you to the Git Proxy channel. Feel free to ping help@finos.org if you encounter any issues. Thanks! |
Git-proxy does a lot "under the hood". For operators, it would be beneficial for git-proxy to emit messages using structured logging using a library such as
winston
to better indicate the state of requests flowing through the system.The text was updated successfully, but these errors were encountered: