Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Slider navigation issues #1

Open
alexiglesias93 opened this issue Jul 11, 2021 · 3 comments
Open

Infinite Slider navigation issues #1

alexiglesias93 opened this issue Jul 11, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@alexiglesias93
Copy link
Member

Made a video showing weird behaviors when changing slides on reverse and when clicking the slider dots:
https://www.loom.com/share/7877c14425af4506aae02c0cceb452a3

@alexiglesias93 alexiglesias93 added the bug Something isn't working label Jul 11, 2021
@alexiglesias93
Copy link
Member Author

@Xlvis great process so far. One thing that you're missing in your implementation is keyboard navigation.
I see you're listening for click events on the slider arrows and dots, but users can also navigate through slides using the arrow keys.
Try it our yourself to understand what I mean.

Also, the sliders have an option of auto-play, which continuously switches slides after X milliseconds. This, again, is not triggered with click events.

I am not a fan of relying just on click events, as you can see, you miss many scenarios where those are not even fired. I would suggest you try to keep track of the currently active slide in a different way, perhaps you could try again using a MutationObserver?

@xlvisben
Copy link

xlvisben commented Aug 2, 2021

@alexiglesias93 I haven't managed to get the slider to work with arrow keys how is it done. I have tried hitting tab key but it hasn't been succesful

@alexiglesias93
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants