-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using Sign In with Apple to create an account displayName value of the auth user is not being set #815
Comments
Closing this in favor of firebase/firebase-ios-sdk#4393. We'll continue updating the issue there. Please let me know if this is actually a different issue. |
@morganchen12 After looking through that issue, I think this is a related, but separate issue. Unless I'm misunderstanding, the Firebase SDK isn't setting the If this is the case it seems like it would then be the responsibility of the FirebaseUI SDK to implement that second call.
|
Good point, I'll address that in this library. |
Hi @KrisConrad, could you help me on this, When using Firebase Auth UI, what all i need to do are:
And, there is a protocol named FUIAuthDelegate to get the callback also. What i want to known is how can I deal with didCompleteWithAuthorization in this case. I don't see the connection between them. |
Hey @langhoangal, the |
@morganchen12 Hi, wondering if there an ETA to get it done? Thanks! |
No, no ETA. :( |
@morganchen12 Apple updated their guidelines and they require Sign-In with Apple starting April 30, 2020 [1]. Are you intending to solve this issue before that date or do still have no ETA? 🤔🙂 |
I'll aim to solve it before then. |
@morganchen12 , any update on this? |
@morganchen12 , do you still have target to solve this before Apple's deadline? |
Hey, unfortunately I have not been able to resolve this before the deadline. You can work around this by prompting your user for a name or fetching the name via Firebase Auth. |
@morganchen12 Deadline has been moved to June 30. |
@morganchen12 Apple already started enforcing this, do we have plan to fix? |
I had to ask user for display name after sign in with apple, till this get fixed |
You can not even fetch the name via Firebase Auth, it's NIL |
This has become more important, Today we got a rejection for our app (see below). I now have a release with a deadline of Monday and not enough time to rip out the FirebaseUI SDK and rewrite our log in flow so we don't have to ask the user for their name:
|
@rosalyntan Would you mind looking into this? |
For anyone else who is in desperate need of getting their app through Apple Review and is in need of a (hopefully temporary) solution I'll share what I'm doing. First I wrote an extension for
Then elsewhere, when setting up the
Lastly, I set up an auth state change listener where I save the
|
Got another app rejection during an update review because this issue again today. Would be super cool if it was ever fixed. |
is there any update on this? |
Hey @Arunperfutil, a fix is in review at https://github.com/firebase/FirebaseUI-iOS/pull/933/files and will be released soon. |
This should be fixed in the latest version of FirebaseUI. Please let me know if that's not the case. |
I think I'm still encountering this issue, on the newest version. I'm using the built in defaultAuthUI, with Google, Facebook, Apple, and Email providers. I'm using the following to propagate changes to the app: Auth.auth().addStateDidChangeListener { (_, user) in
print(user)
print(user?.email)
print(user?.displayName)
self.user = user
} When I login with apple, I'm getting this in my logs:
So the email is being persisted, but it looks like the name isn't. Any ideas if this is the same problem? Even weirder... AFTER logging in with Apple, if I try to go back to logging in with Google or Facebook or something else, I continue receiving an empty string for the display name... Then, if I go into the Firebase Auth console and delete the user - I can restart and recreate the error Here's a screen recording showing the issue: Highlights:
So, it almost seems like logging in with Apple never gives the name, and ends up corrupting the other auth methods, so that the name is no longer available for any of them (?) @morganchen12 any ideas? Here's the firebaseui portion of my podfile.lock:
|
My app is getting rejected by Apple Review because of this. I'm going to try @KrisConrad suggestion but would be great if you guys could get this working. Update - I do believe the changes from https://github.com/firebase/FirebaseUI-iOS/pull/933/files do work in updating the So what I ended up doing was swizzling as recommended by @KrisConrad, however I am not calling |
Fixed upstream in Firebase Auth. firebase/firebase-ios-sdk#10068 |
So by closing this are we indicating that there should be no required changes within the auth UI library? Not even a version update? Should users of the library just start seeing the display name always populated for Apple login users? Cc @morganchen12 |
Hi, I'm getting an App Store rejection because I can't debug this, because it is only happening on Apple's test devices, not on my local machine. Does anybody have any ideas? I'm wondering if it is because the testers are testing many apps on the same device, using the same Apple accounts, and more than one of these apps uses Firebase Auth to sign in? At least the email address (and possibly also |
Step 1: Are you in the right place?
Step 2: Describe your environment
Step 3: Describe the problem:
Steps to reproduce:
Observed Results:
Auth.auth().currentUser?.displayName in nil
Expected Results:
For Auth.auth().currentUser?.displayName to be set to the fullName value of the ASAuthorizationAppleIDCredential passed into the authorizationController:didCompleteWithAuthorization method of the ASAuthorizationControllerDelegate
The text was updated successfully, but these errors were encountered: