Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Documented acceptance testing #409

Merged
merged 10 commits into from Oct 26, 2016
Merged

WIP Documented acceptance testing #409

merged 10 commits into from Oct 26, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2016

🚨 Do not merge, work in progress 🚨

First steps towards setting up a standard practice for acceptance testing with EmberFire. This should include:

  • new docs including example test code, and
  • test helpers and blueprints that match existing ember acceptance testing patterns.

Progress:

  • Define an acceptance test module for Qunit, add to emberfire blueprint.
  • Add docs for standard approach including instructions for fixture data
  • Add module definition and example test for Mocha users.
  • Add access to the firebase ref in the acceptance test
  • Add instructions for handling changes to data, e.g. updates, additions, deletions
  • Manually test example code with a basic ember app.

Potentially out of scope:

  • Add acceptance tests to the dummy app
  • Consider implications of trying to stub multiple Firebase instances.
  • Updating Emberfire's acceptance tests to use the new module.

Notable considerations:

N.B. merging into branch acceptance-testing

cc @tstirrat

@ghost
Copy link
Author

ghost commented Jul 9, 2016

Related to #349

@ghost ghost changed the title WIP Emberfire acceptance testing WIP Documented acceptance testing Jul 9, 2016
@villander
Copy link

Awesome @binhums 💃

@jemware
Copy link

jemware commented Jul 18, 2016

+1

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@tstirrat
Copy link
Contributor

Going to squash and merge this into another branch to clean it up (CLA errors are due to my own email being misconfigured on github)

@tstirrat tstirrat merged commit 82ed20c into FirebaseExtended:acceptance-testing Oct 26, 2016
@tonycoco
Copy link

Any plan to add this? Also needed would be auth mocks.

dandehavilland pushed a commit to dandehavilland/emberfire that referenced this pull request Oct 7, 2017
@tpetrone
Copy link

tpetrone commented May 9, 2018

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants