You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Our Sentry has captured about 20,000 messaging/internal-error errors. This means that due to some internal FCM error, we haven't sent 20,000 push notifications to our users.
It would be nice to change the default retry configuration or allow library users to use their own retry configs. It seems the solution is already implemented in #1739 but stuck in review phase for 2 years.
Describe alternatives you've considered
I considered writing a custom wrapper around the FCM error, but it appears that FCM doesn't expose the Retry-After header, making it unclear how long the wrapper should wait before making another request.
Additionally, copying and pasting the same wrapper in each project that uses FCM is a very frustrating experience
The text was updated successfully, but these errors were encountered:
For about 800 of tokens I noticed this today aswell. I don't have a system in place to try again later for these customers. So they are currently lost.
For our system its "not so bad", therefore I havent invested time in that topic.
Is your feature request related to a problem? Please describe.
Our Sentry has captured about 20,000 messaging/internal-error errors. This means that due to some internal FCM error, we haven't sent 20,000 push notifications to our users.
Describe the solution you'd like
FCM documentation recommends retrying such requests. https://firebase.google.com/docs/cloud-messaging/send-message#admin.
Currently, the library retries 503 requests but not 500 (messaging/internal-error returns 500)
firebase-admin-node/src/utils/api-request.ts
Line 202 in b5c4f5a
It would be nice to change the default retry configuration or allow library users to use their own retry configs. It seems the solution is already implemented in #1739 but stuck in review phase for 2 years.
Describe alternatives you've considered
I considered writing a custom wrapper around the FCM error, but it appears that FCM doesn't expose the Retry-After header, making it unclear how long the wrapper should wait before making another request.
Additionally, copying and pasting the same wrapper in each project that uses FCM is a very frustrating experience
The text was updated successfully, but these errors were encountered: