Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document usage of arrayUnion() & arrayRemove() #348

Closed
debuggingfuture opened this issue Sep 3, 2018 · 9 comments
Closed

document usage of arrayUnion() & arrayRemove() #348

debuggingfuture opened this issue Sep 3, 2018 · 9 comments
Assignees

Comments

@debuggingfuture
Copy link

  • Firebase SDK version: v0.16.1

Are they currently supported as in googleapis/nodejs-firestore#287 ? if so, please update the document at https://firebase.google.com/docs/firestore/manage-data/add-data

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@schmidt-sebastian
Copy link
Contributor

@samtstern is going to take care of this.

@samtstern
Copy link
Contributor

Part one:
firebase/snippets-node@5ad041a

@samtstern
Copy link
Contributor

Part two:
GoogleCloudPlatform/java-docs-samples#1207

@hiranya911
Copy link
Contributor

@schmidt-sebastian can this be closed now?

@schmidt-sebastian
Copy link
Contributor

Yes!

@bilics
Copy link

bilics commented Dec 4, 2018

It does not seem to be working when the field does not yet exist.

Is this the intended behaviour ?

Thanks

@schmidt-sebastian
Copy link
Contributor

These operators create the field if the field does not yet exist, or convert it to an array if it is of a different type. Does this not work for you?

@bilics
Copy link

bilics commented Dec 10, 2018

Hi @schmidt-sebastian - sorry, my mistake - it does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants