-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase Auth is failing on Safari 16.1 (destructuring error) #6636
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
I see this with Safari 16.0 too.. But the modular demo app and the auth-compat demo app from firebase-js-sdk are working ok for me. Closing this and leaving the firebaseui issue open. |
we're seeing the same issue with Safari 16.1 beta and we don't use firebaseui, only standard firebase-js-sdk. |
I ended up using a workaround by managing the auth redirects myself. This also provides an offramp for firebase, if you're only using the js sdk for auth. firebase/firebaseui-web#977 (comment) |
This should still be open. We are still seeing the issue. |
Can also confirm we're seeing this with just the firebase-js-sdk (not using firebaseui). If it helps, switching to |
[REQUIRED] Describe the problem
Firebase UI does not work with Safari on Mac or iPhone.
Steps to reproduce:
Additionally: these steps work fine with Chrome on the same Mac.
Relevant Code:
N/A
Seen in console:
TypeError: Right side of assignment cannot be destructured
The event it is receiving seems to be a window Message event, and not the JSON contained within
data
which is what contains the fields to be destructured.Crosspost from firebase/firebaseui-web#977
I believe the bug is in the js sdk as the relevant file is in this source file:
firebase-js-sdk/packages/auth/src/core/strategies/abstract_popup_redirect_operation.ts
Line 86 in b6c231a
From my understanding of the stack trace, I think the js sdk uses iframes to communicate, and there's some sort of message passing failure happening.
The text was updated successfully, but these errors were encountered: