Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undici <v6.16.0 memory ballooning bug #8431

Closed
JesperLindholmNG opened this issue Aug 16, 2024 · 2 comments · Fixed by #8432
Closed

undici <v6.16.0 memory ballooning bug #8431

JesperLindholmNG opened this issue Aug 16, 2024 · 2 comments · Fixed by #8432
Assignees

Comments

@JesperLindholmNG
Copy link

JesperLindholmNG commented Aug 16, 2024

Operating System

macOS

Browser Version

Firefox

Firebase SDK Version

10.13.0

Firebase SDK Product:

Auth

Describe your project's tooling

React, Next.js

Describe the problem

The undici dependency contains a code path that, starting with Node 20.16.0, results in memory leaks (in our experience significant). See nodejs/undici#3445 and nodejs/node#54274 for details about the issue.

Upgrading undici to v6.19.6 or later, will include the fix. As of yet the fix does not appear to be backported to v5 which this repository uses.

Steps and code to reproduce issue

See nodejs/undici#3445 for more details.

@JesperLindholmNG JesperLindholmNG added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Aug 16, 2024
@aalej aalej added api: core needs-attention and removed new A new issue that hasn't be categoirzed as question, bug or feature request labels Aug 16, 2024
@dlarocque
Copy link
Contributor

dlarocque commented Aug 19, 2024

Hi @JesperLindholmNG, thanks for reporting this issue.

It seems that upgrading to undici 6.19.6 is non-trivial for us. Fortunately, we do plan to replace our usage of undici with native fetch in the coming months, which will resolve this issue- I'll update this issue with any updates as they come.
Edit: My bad, I didn't see #8432!

@DellaBitta
Copy link
Contributor

Hi @JesperLindholmNG,

I've updated our undici dependency to v6.19.7, which will be part of our next release. I'm going to close this issue for now. Please create a new issue if you encounter any problems with the new version. Thanks!

@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants