From e8e4bf7ff317d736095501d1c46d27d676f4a092 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 29 Sep 2020 14:50:47 -0700 Subject: [PATCH 1/2] Fix compile error --- packages/firestore/lite/src/api/transaction.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/firestore/lite/src/api/transaction.ts b/packages/firestore/lite/src/api/transaction.ts index d29cde7d498..bd84a9ece3a 100644 --- a/packages/firestore/lite/src/api/transaction.ts +++ b/packages/firestore/lite/src/api/transaction.ts @@ -123,9 +123,14 @@ export class Transaction { * * @param documentRef A reference to the document to be set. * @param data An object of the fields and values for the document. + * @param options An object to configure the set behavior. * @return This `Transaction` instance. Used for chaining method calls. */ - set(documentRef: DocumentReference, data: Partial): this; + set( + documentRef: DocumentReference, + data: Partial, + options: SetOptions + ): this; set( documentRef: DocumentReference, value: T, From c2ac5d17d7acf2051cae518fb457d47c9c9f94bc Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 29 Sep 2020 14:52:26 -0700 Subject: [PATCH 2/2] Create neat-crews-rule.md --- .changeset/neat-crews-rule.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/neat-crews-rule.md diff --git a/.changeset/neat-crews-rule.md b/.changeset/neat-crews-rule.md new file mode 100644 index 00000000000..2b140b68814 --- /dev/null +++ b/.changeset/neat-crews-rule.md @@ -0,0 +1,5 @@ +--- +"@firebase/firestore": patch +--- + +Internal changes to support upcoming modular API.