Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth emulator modify secuirity #3044

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Jan 15, 2021

Description

Fixes #3013

Changes security requirements for Auth Emulator APIs. The gen-auth-api-spec.ts script has been modified and ran, as a result, apiSpec.js and schema.ts files have been updated. Unit tests have been updated to reflect the bug fix.

Scenarios Tested

Manually ran repro in #3013 and verified things are fixed.

Sample Commands

firebase emulators:start

@ssbushi ssbushi requested a review from yuchenshi January 15, 2021 18:21
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Jan 15, 2021
@yuchenshi yuchenshi merged commit f7d5ef7 into master Jan 15, 2021
@yuchenshi yuchenshi deleted the auth-emulator-modify-secuirity branch January 15, 2021 18:41
ssbushi added a commit that referenced this pull request Jan 15, 2021
bkendall added a commit that referenced this pull request Jan 15, 2021
* Removed security requirements for Auth Emulator APIs

* Undo changes to package.json

* Update changelog for Fix #3044

* Prettified CHANGELOG

Co-authored-by: Bryan Kendall <bkend@google.com>
This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear user accounts endpoint not working as intended
2 participants