Use u32
to describe vsock related buffer sizes
#4627
Labels
Good first issue
Indicates a good issue for first-time contributors
Priority: Low
Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Status: Parked
Indicates that an issues or pull request will be revisited later
In #4556, we updated our generic virtio buffer handling code to describe buffer sizes using
u32
instead ofusize
, since the virtio specification states that lengths of virtio-buffers fit intou32
(and header fields in the virtio protocol describing lengths are typed to be 32 bit integers).From that work, a small follow up is possible in the vsock module, where we can now also describe lengths of vsock packages using
u32
instead ofusize
. This will allow us to get rid of a few more explicit casts. Particularly, we can do the following changes to function signatures:VsockConnection::peer_avail_credit
can returnu32
VsockPacket::buf_size
can returnu32
VsockPacket::read_at_offset_from
should be(&self, &mut T, u32, u32) -> Result<u32, VsockError>
(e..g. the conversion to usize should only happen right around thewrite_volatile_at
callVsockPacket::write_from_offset_to
Maybe we can even get away with changing the arguments
IoVecBuffer[Mut]::{read,write}_volatile_at
tou32
sThe text was updated successfully, but these errors were encountered: