-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds report node type #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psyched about this! Thank you for picking it up in such short order!
I added Reports as their own section under the Project nav. Do we like it there?
I had the same thought, and I think this is right. I really like organizing these by type, too. The obvious question is around projects that may someday have dozens of these, since there isn't an additional mechanism for subfoldering. Type > maturity (high/medium/low/unknown)?
I picked orange for the DAG node color.... don't think that i love it, but there's certainly space to change that pretty easily!
Funny. For no reason in particular, I was thinking goldenrod—my favorite Pokémon city—so not far off.
Do we like the way info is being rendered in the table details? I think it's imperfect, but maybe passable for the time being.
More than passable! Two small things:
- Is it possible to remove
TAGS
for now? I know that's more or less built in to every node type, it's just that reports cannot be tagged—yet, someday they probably should be. - I really like the "View this report" button! Not sure I'm sold on prepending the link to the description in addition
Last note: could you add a report
or two to the ci-project
+ recompile artifacts, so that they'll show up in PR previews?
@jtcohen6 the latest commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for those updates!
Only small thing is that while I see the updated manifest.json
, I don't see the associated changes to ci-project
to add the two reports
resolves #135
Description
This PR adds:
Additionally, this PR:
I can split this single PR into a couple of different smaller PRs if desired. This all needs to get vendored back into Core though, so I figured it was ok :)
Some specific feedback I'm looking for, though all is welcomed!
TODO before merge:
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.