Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt 0.18.0 support #103

Merged
merged 7 commits into from
Sep 14, 2020
Merged

dbt 0.18.0 support #103

merged 7 commits into from
Sep 14, 2020

Conversation

beckjake
Copy link
Contributor

Bump dbt to 0.18.0rc1

Make a number of changes to support dbt-adapter-tests. A future PR will wire those up to this project (requires dbt-labs/dbt-adapter-tests/pull/3)

@beckjake beckjake requested a review from jtcohen6 August 21, 2020 19:20
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on loading seeds with timestamp columns into Databricks

FACTORY.plugins[key] = plugin


def inject_adapter(value, plugin):
"""Inject the given adapter into the adapter factory, so your hand-crafted
artisanal adapter will be available from get_adapter() as if dbt loaded it.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is funny

@jtcohen6
Copy link
Contributor

Do you want to also make the change around get_catalog + submit_connected that you mentioned here? Or we can open a new issue + PR

@beckjake beckjake requested review from gshank and kwigley August 25, 2020 13:27
@beckjake beckjake merged commit 7309950 into master Sep 14, 2020
@beckjake beckjake deleted the feature/dbt-0.18.0-support branch September 14, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants