Include incremental materializations in package distribution #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
LGTM! I installed in a local virtualenv as pip install .[all]. (nice touch), the incremental macro files show up in env/lib/python3.8/site-packages/dbt_spark-0.19.0-py3.8.egg-info/SOURCES.txt, I ran an incremental model, everything just worked.
I like the use of MANIFEST.in for real recursive inclusion.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves issue with 0.19.0 distribution with missing incremental materializations (
dbt/include/spark/macros/materializations/incremental)Description
Used a
MANIFEST.infile to define what non-python files to include (docs)Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.