Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow floats in package version fields #2518

Closed
beckjake opened this issue Jun 9, 2020 · 1 comment
Closed

Allow floats in package version fields #2518

beckjake opened this issue Jun 9, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@beckjake
Copy link
Contributor

beckjake commented Jun 9, 2020

Describe the feature

A lot of existing packages have versions like '1.0'. In native env rendering, this becomes 1.0, which is a float, and that fails validation. The workaround is to use "{{ 1.0 | as_text }}", which people hate. We should just allow users to supply floats for git revisions/package versions and then convert them to strings internally when before doing version-y things.

Describe alternatives you've considered

Tell people to use {{ 1.0 | as_text }}, over and over again.

Additional context

There are other fields, but probably none as egregious as this one.

Who will this benefit?

End users of packages.

@beckjake beckjake added enhancement New feature or request triage labels Jun 9, 2020
@drewbanin drewbanin removed the triage label Jun 10, 2020
@drewbanin drewbanin added this to the 0.17.1 milestone Jun 10, 2020
beckjake added a commit that referenced this issue Jun 15, 2020
…e-version-floats

allow floats for package versions, add a test with a float-like branch (#2518)
@beckjake
Copy link
Contributor Author

Fixed in #2535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants