Change dbt list command to always return 0 as exit code #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
reviewed
Nov 17, 2020
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| - Fix Redshift adapter `get_columns_in_relation` macro to push schema filter down to the `svv_external_columns` view ([#2855](https://github.com/fishtown-analytics/dbt/issues/2854)) | |||
| - Add `unixodbc-dev` package to testing docker image ([#2859](https://github.com/fishtown-analytics/dbt/pull/2859)) | |||
| - Increased the supported relation name length in postgres from 29 to 51 ([#2850](https://github.com/fishtown-analytics/dbt/pull/2850)) | |||
| - dbt list command always return 0 as exit code ([#2866](https://github.com/fishtown-analytics/dbt/issues/2886)) | |||
There was a problem hiding this comment.
Suggested change
| - dbt list command always return 0 as exit code ([#2866](https://github.com/fishtown-analytics/dbt/issues/2886)) | |
| - dbt list command always return 0 as exit code ([#2886](https://github.com/fishtown-analytics/dbt/issues/2886), [#2892](https://github.com/fishtown-analytics/dbt/issues/2892)) |
Could you also add yourself to the list of Contributors below?
jtcohen6
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2886
Description
Change 'dbt list' command to always return 0 as exit code
First PR, any comment is greatly appreciated
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.