Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration test failure due to timezone #3344

Merged
merged 2 commits into from
May 13, 2021

Conversation

peiwangdb
Copy link
Contributor

@peiwangdb peiwangdb commented May 11, 2021

resolves #3297

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 11, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @peiwangdb.

This change doesn't need an entry on the changelog, but I'd still love to have on the list of v0.20 contributors! Could you add yourself?

https://github.com/fishtown-analytics/dbt/blob/1f33b6a74a614aa346824f16c5629e4d910d2106/CHANGELOG.md#L59

@peiwangdb peiwangdb requested a review from jtcohen6 May 13, 2021 01:07
@peiwangdb
Copy link
Contributor Author

@jtcohen6 thanks for the approval! I updated the changelog :)

@jtcohen6 jtcohen6 merged commit fbfef4b into dbt-labs:develop May 13, 2021
kwigley pushed a commit that referenced this pull request May 19, 2021
* fix integration test failure due to timezone

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure with "make integration-fail-fast" command
2 participants