Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update environment setup in CONTRIBUTING.md #1199

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Update environment setup in CONTRIBUTING.md #1199

merged 1 commit into from
Dec 21, 2018

Conversation

vijaykiran
Copy link
Contributor

  • Document command to activate the virtualenv
  • Fix minor typo

@vijaykiran
Update environment setup in CONTRIBUTING.md
09fbe28 
- Document command to activate the virtualenv
- Fix minor typo
@drewbanin drewbanin changed the base branch from dev/grace-kelly to dev/stephen-girard December 21, 2018 18:05
beckjake
beckjake approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for the contribution!

@drewbanin
Copy link
Contributor

^ I cancelled these tests b/c this is a docs only change.

@drewbanin drewbanin merged commit dcc017d into dbt-labs:dev/stephen-girard Dec 21, 2018
@vijaykiran vijaykiran deleted the update-contributing-doc branch January 3, 2019 11:11
@vijaykiran vijaykiran restored the update-contributing-doc branch January 3, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijaykiran @drewbanin @beckjake