Fix bigquery snowflake unknown relation types #1872
Conversation
…nize the table type
For bigquery:
if a relation type is not known, use 'RelationType.External' in place of None
For snowflake/other sql adapters:
if the relation type returned by list_relations_without_caching macro is not
a known RelationType, treat it as External
|
I had assumed that the fix for #1868 would involve a change to the catalog query! I'm happy to replace |
|
I think this is the more correct fix actually. dbt really only cares about views and tables, and should just be able to treat everything else as "external". We support materialized views because eh, whatever, but I think this is more sustainable long-term instead of adding new stuff all the time. Also it was hard to tell from the issue where the message actually came from, but I figured this is the only spot in dbt right now that's going to set a table type field that's declared as |
These fixes are kind of speculative, I can't come up with a nice way to reproduce them. But they make sense to me as errors and I am reasonably confident in the fixes.
For bigquery, instead of defaulting to
Noneif the relation type isn't immediately recognized, we default toExternal.Similarly, in the SQL adapters no longer pass along whatever the
list_relations_without_cachingmacro returns. Instead, check that it's something we support and if it isn't, mark it "external".Fixes #1868
Fixes #1869