Fix bigquery case sensitive caching issue (#1810) #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
changed the title
beckjake
force-pushed
the
fix/bigquery-case-sensitive
branch
2 times, most recently
from
1e9978c
to
13c68c1
Compare
drewbanin
reviewed
Nov 1, 2019
| def check_schema_exists(self, database, schema): | ||
| return super().check_schema_exists(database, schema) | ||
| @available.parse(lambda *a, **k: False) | ||
| def check_schema_exists(self, database: str, schema: str) -> bool: |
| @classmethod | ||
| def get_include_policy(cls, relation, information_schema_view): | ||
| schema = True | ||
| if information_schema_view in ('SCHEMATA', 'SCHEMATA_OPTIONS', None): |
beckjake
force-pushed
the
fix/bigquery-case-sensitive
branch
2 times, most recently
from
adfed29
to
d5c7b0c
Compare
drewbanin
approved these changes
Nov 4, 2019
| @@ -294,7 +294,14 @@ def drop_dataset(self, database, schema): | |||
| client = conn.handle | |||
|
|
|||
| with self.exception_handler('drop dataset'): | |||
| for table in client.list_tables(dataset): | |||
| try: | |||
There was a problem hiding this comment.
can we replace this with:
client.delete_dataset(dataset_id, delete_contents=True, not_found_ok=True)
If the version of google-cloud-bigquery that we use supports it? If not, we can tackle it in a subsequent PR / release.
via the bq docs
There was a problem hiding this comment.
It looks like we can set a minimum of 1.15.0 and be sure we have that flag available - it's hard to find any information about earlier versions.
There was a problem hiding this comment.
ok - let's make that change in this PR then.
added 5 commits
November 4, 2019 12:23
Implement more things via macros Refactor Relations vs InformationSchemas to handle BQ better Fix a bug where bigquery cached uppercase schema names wrong - by using information_schema this just goes away :)
beckjake
force-pushed
the
fix/bigquery-case-sensitive
branch
from
1ea3cd7
to
670c26b
Compare
|
I had to rebase onto louisa-may-alcott and drop the |
beckjake
force-pushed
the
fix/bigquery-case-sensitive
branch
from
ffcf7af
to
670c26b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1810
Fixes #1887
Refactor Relations vs InformationSchemas to handle BQ better
Fix a bug where bigquery cached uppercase schema names wrong.
Use
exists_ok,not_found_ok, anddelete_contentsflags on bigquery dataset operations instead of implementing them manually.