Parse model hooks for refs (#1957) #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parse pass for model hooks, parse them like models Attach the hook refs as if they were on the model Add a test exercising refs
drewbanin
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
This is great! I do think it means that pre/post-hooks now need to be executable at parse-time. For typical uses of hooks, that shouldn't be a problem. I do wonder if there aren't folks doing wacky stuff with statements in hooks that are going to have a bad time.
I'll be sure to document this as a breaking change so that folks can add an if execute if required
|
Good point! I hadn't considered that. |
|
Hello! How can i know if this PR was merged into master and to which Release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1957
Add a parse pass for model hooks, parse them like models, attach the hook refs as if they were on the model.
Add a test exercising refs in model hooks.