Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add macro argument definitions (#2081, #2083) #2096

Merged
merged 2 commits into from
Feb 10, 2020
Merged

add macro argument definitions (#2081, #2083) #2096

merged 2 commits into from
Feb 10, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 4, 2020 •
edited
Loading

Fixes #2081
Fixes #2083

  • Add describable arguments field to macros, it's a list of objects that have descriptions
  • Render those descriptions just like the macro descriptions are rendered.
  • Remove the idea of docrefs: always render everything at compile time. At parse time doc only verifies it got one or two arguments now.

@cla-bot cla-bot bot added the cla:yes label Feb 4, 2020
@beckjake beckjake changed the title add macro argument definitions (#2081) add macro argument definitions (#2081, #2083) Feb 4, 2020
@beckjake beckjake force-pushed the feature/contexts-redux branch 2 times, most recently from 148ef0d to 2e5fdbf Compare February 6, 2020 15:59
@beckjake beckjake changed the base branch from feature/contexts-redux to dev/barbara-gittings February 7, 2020 19:09
drewbanin
drewbanin approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! This LGMT :)

@beckjake beckjake merged commit dcce90b into dev/barbara-gittings Feb 10, 2020
@beckjake beckjake deleted the feature/document-macro-args branch February 10, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird rendering behavior for schema.yml descriptions Describe macro arguments in schema.yml files
2 participants
@beckjake @drewbanin