removing the requirement to have a passphrase on a Snowflake key #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
suggested changes
Feb 27, 2020
There was a problem hiding this comment.
Thanks for your contribution @mhmcdonald! This looks great!
It appears to me that this resolves #1805, so I've linked that up - please let me know if I was incorrect there. I've put in one suggested change to include the link to that issue in the changelog as well.
Also, please add yourself to to the contributors list for this release!
Co-Authored-By: Jacob Beck <beckjake@users.noreply.github.com>
beckjake
approved these changes
Feb 27, 2020
done! I think this should be good to go. thanks, @beckjake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1805
Description
This PR removes the requirement to have a passphrase when authenticating with a Snowflake key pair. Snowflake key pairs without passphrases are supported by Snowflake, but are not currently supported by dbt.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.