Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render profile_name in the base context (#2230) #2251

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Mar 26, 2020

resolves #2230

Description

Render the profile field in dbt_project.yml in the base context.

This does not render the project name field in any context, as that makes everything extra difficult and impacts plugin loading. Previously we did allow this, but behavior was inconsistent: It would only act sensibly if the project with a variable name was the root project.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@beckjake beckjake requested a review from drewbanin March 26, 2020 18:45
@cla-bot cla-bot bot added the cla:yes label Mar 26, 2020
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ship it!

@beckjake
Copy link
Contributor Author

beckjake commented Apr 1, 2020

Merging this before tests run - just resolved a CHANGELOG.md conflict

@beckjake beckjake merged commit b385d17 into dev/0.16.1 Apr 1, 2020
@beckjake beckjake deleted the fix/render-profile-name-base-context branch April 1, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants