Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the create adapter script to dbt 0.16.1 #2294

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Apr 3, 2020

resolves #2145

Description

Update the create adapter script to dbt 0.16.1

Make the base dbt version in the script managed by bumpversion

I would love to add a test that this hasn't regressed in a future PR. My current line of thought was:

  • run the script to create a sqlite adapter skeleton
  • commit that
  • build out something that passes dbt debug (implement the missing methods)
  • get the diff, store that as a patch
  • make a test that runs the script, applies the patch, and ensures dbt debug passes

But that feels like a whole project, and I think we want to get the 0.16.1 rc out. I'm quite happy to do that in this PR if that's deemed reasonable.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Make the base dbt version in the script managed by bumpversion
@cla-bot cla-bot bot added the cla:yes label Apr 3, 2020
@beckjake beckjake requested a review from drewbanin April 3, 2020 16:33
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's definitely prioritize the SQLite approach in the future, but no need to hold up 0.16.1 in that regard. Glad we're making this change regardless.

Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants