Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redshift diststyle behavior #2298

Merged

Conversation

rodrigodelmonte
Copy link
Contributor

@rodrigodelmonte rodrigodelmonte commented Apr 6, 2020

resolves #2246

Description

  • Don't provide a diststyle to redshift tables when configured as "auto"

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented Apr 6, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @rodrigodelmonte

@rodrigodelmonte rodrigodelmonte changed the title Change redshift diststyle behavior (#2246) Change redshift diststyle behavior Apr 6, 2020
@drewbanin
Copy link
Contributor

Thanks @rodrigodelmonte! This looks good to me -- i'll kick off the tests here :)

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Apr 6, 2020
@cla-bot
Copy link

cla-bot bot commented Apr 6, 2020

The cla-bot has been summoned, and re-checked this pull request!

@rodrigodelmonte rodrigodelmonte marked this pull request as ready for review April 6, 2020 13:48
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here LGTM!

One more quick change request though -- can you add yourself to the list of Contributors for this release in the CHANGELOG.md file? We want to make sure you get credit for your contribution :D

Thanks!

@rodrigodelmonte rodrigodelmonte force-pushed the fix-diststyle-auto branch 2 times, most recently from d5f19de to 2fe6fda Compare April 7, 2020 20:31
  * Don't provide a diststyle to redshift tables when configured as "auto"
@rodrigodelmonte
Copy link
Contributor Author

@drewbanin
Thanks for the reminder, done!

@drewbanin
Copy link
Contributor

Alright alright, thanks @rodrigodelmonte! It looks like there's a changelog merge conflict - do you mind if I fix that up for you real quick? I'm happy for you to do it as well, lmk if you'd like a hand at all. Going to ship this as soon as that conflict is addressed!

@rodrigodelmonte
Copy link
Contributor Author

rodrigodelmonte commented Apr 9, 2020

@drewbanin Let me know if it is fine now!
Should I have just one commit or can you squash the 2 commits ?

@drewbanin
Copy link
Contributor

This is great as-is. I'm going to merge it presently. Thanks for contributing to dbt!

@drewbanin drewbanin merged commit d2760d5 into dbt-labs:dev/octavius-catto Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't provide a diststyle to redshift tables when diststyle is configured as "auto"
2 participants