Move pytest-logbook dependency to dev_requirements.txt

[aburgel]

Description

pytest-logbook is only used for testing dbt, so I don't think it should be a dependency of dbt-core. I've moved it to dev_requirements.txt so it should still be available for tests.

I came across this because my project has a dependency on dbt-core and also uses pytest. pytest's caplog fixture stopped working when we upgraded dbt to 0.15.3. I was able to trace this back to pytest-logbook which installs its own log capture fixture and disables (breaks?) the builtin one.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @aburgel

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @aburgel

[beckjake]

@cla-bot check

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @aburgel

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[beckjake]

Hey @aburgel, thanks for your contribution! I'm not sure why the cla-bot accepted your PR initially, but we'll definitely need to have you sign that before we can merge this. I'm very interested in getting this fix in to 0.17.0 and cutting a new RC in the immediate future, so please let me know if you're having any trouble on that front!

[aburgel]

@beckjake Working on it now. Just confirming with my company which document I need to sign.

[aburgel]

@beckjake Just submitted the CLA!

[beckjake]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[beckjake]

Thanks @aburgel! Looks good, but I have some bad news - we already released rc4, which we really really hope is the last RC.

I think I'm fine with merging this in for the 0.17.0 release since it appears very low-risk and actually bit me a couple times on my current work - @drewbanin what's your take on this?

Assuming we do decide we want this for 0.17.0, it would be great if you could pull in/rebase onto current dev/octavius-catto and update your changelog entry to be at the top, instead of where it is now (I think it'll show as under rc4 after merge).

[aburgel]

@beckjake just rebased and moved the changelog entry. my bad for not getting the CLA signed sooner, took a bit for our legal team to review.

[drewbanin]

@beckjake I'm ok with merging this for 0.17.0-final - can you work to kick off the tests again and get this merged?

Thanks for your contribution @aburgel :)

[beckjake]

All merged, this will make it into 0.17.0 - thanks again!