Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: common artifact metadata #2778

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2761

Description

Add a common metadata field to the four JSON artifact files, which includes the dbt schema version and the dbt version.

For the manifest, this is additive to the existing metadata field.

The source freshness output has been adjusted as described in #2493 to be more in line with the other files, which made the rest of this a bit easier.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 21, 2020
Base automatically changed from feature/schema-versions to dev/kiyoshi-kuromiya September 21, 2020 20:10
Adjusted how schema versions are set
RPC calls no longer have the schema version in their replies
@beckjake beckjake force-pushed the feature/common-artifact-metadata branch from 5906486 to 8379edc Compare September 22, 2020 16:35
@beckjake beckjake force-pushed the feature/common-artifact-metadata branch from da80bf2 to 204b02d Compare September 22, 2020 18:49
@beckjake beckjake marked this pull request as ready for review September 22, 2020 19:03
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@beckjake beckjake merged commit 120eb5b into dev/kiyoshi-kuromiya Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Artifacts: Common metadata field
3 participants