Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BigQuery] Allow more recent versions of google-api-core? #2794

Closed
max-sixty opened this issue Sep 27, 2020 · 2 comments · Fixed by #2877
Closed

[BigQuery] Allow more recent versions of google-api-core? #2794

max-sixty opened this issue Sep 27, 2020 · 2 comments · Fixed by #2877
Labels
enhancement New feature or request

Comments

@max-sixty
Copy link
Contributor

Describe the feature

Currently dbt-bigquery has an upper limit of 1.16 on google-api-core. That release is from Jan of this year.

Would it be possible to loosen that?

While it's clearly not dbt's responsibility for us to be able to install arbitrary packages, here's an example where we can't instally google-cloud-bigquery-datatransfer because of this restriction:

[SolverProblemError]
Because no versions of google-cloud-bigquery-datatransfer match >2.0.0,<3.0.0
 and google-cloud-bigquery-datatransfer (2.0.0) depends on google-api-core (>=1.22.2,<2.0.0dev), google-cloud-bigquery-datatransfer (>=2.0.0,<3.0.0) requires google-api-core (>=1.22.2,<2.0.0dev).
And because dbt-bigquery (0.18.0) depends on google-api-core (>=1.16.0,<1.17.0), google-cloud-bigquery-datatransfer (>=2.0.0,<3.0.0) is incompatible with dbt-bigquery (0.18.0).
And because dbt (0.18.0) depends on dbt-bigquery (0.18.0)
 and no versions of dbt match >0.18.0,<0.19.0, google-cloud-bigquery-datatransfer (>=2.0.0,<3.0.0) is incompatible with dbt (>=0.18.0,<0.19.0).
So, because {repo} depends on both dbt (^0.18.0) and google-cloud-bigquery-datatransfer (^2.0.0), version solving failed.

Thanks as ever for the awesome product!

@max-sixty max-sixty added enhancement New feature or request triage labels Sep 27, 2020
@drewbanin drewbanin removed the triage label Sep 28, 2020
@drewbanin
Copy link
Contributor

hey @max-sixty - sure thing - we'd be super happy to expand this version range as long as there are no breaking changes we'd need to account for.

I scanned through the changelog and i don't see anything too controversial in there. I'd be supportive of changing the upper bound to 1.21.0.

We probably do not want to set the upper bound to <2.0.0 because breaking changes in libraries like this one can (and do) break older versions of dbt down the line. You buy it?

@max-sixty
Copy link
Contributor Author

Superb! That would be perfect. Thank you as ever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants