convert cli-style strings in selectors to normalized dictionaries #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
string_selectors
branch
2 times, most recently
from
b82705d
to
53f88aa
Compare
jtcohen6
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Works great for me in local testing. Thanks so much for the spade work here, it's such a quality-of-life improvement for artifact users (including ourselves over in dbt-labs/dbt-docs#119).
kwigley
suggested changes
Nov 18, 2020
gshank
force-pushed
the
string_selectors
branch
2 times, most recently
from
f20954e
to
2dcfd0f
Compare
gshank
force-pushed
the
string_selectors
branch
from
2dcfd0f
to
bb83435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#2879]
resolves #2879
Description
Process the dictionary created from the selectors.yml to convert cli-string-style definitions to dictionaries, for the 'selectors' saved in manifest.json
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.