Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposure parsing to allow other resources with the same name #3009

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

kwigley
Copy link
Contributor

@kwigley kwigley commented Jan 13, 2021

resolves #2969

Description

Exposure parsing occurs after all other node types have been parsed. #2920 made exposures "documentable" which caused this node type to be parsed twice. Once with TestablePatchParser and once with the appropriate ExposureParser. This PR skips the TestablePatchParser step.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 13, 2021
@kwigley kwigley self-assigned this Jan 13, 2021
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good when I tested locally

@kwigley kwigley merged commit 43da603 into dev/kiyoshi-kuromiya Jan 14, 2021
@kwigley kwigley deleted the fix/exposure-parsing branch January 14, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Defining properties for model + exposure with same name raises exception
3 participants