bugfix: ignore commented-out schema tests #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
force-pushed
the
bug/ignore-commented-schema-tests
branch
from
ef5e533
to
4b381fa
Compare
drewbanin
reviewed
Mar 14, 2017
dbt/parser.py
Outdated
| @@ -256,6 +256,9 @@ def parse_schema_tests(tests, root_project, projects): | |||
|
|
|||
| for model_name, test_spec in test_yml.items(): | |||
| for test_type, configs in test_spec.get('constraints', {}).items(): | |||
There was a problem hiding this comment.
can we also check if test_spec is None? That would happen here:
test_model:
constraints:
# unique:
#- some_fieldEdge case, but would be good to avoid the ol stack trace :)
There was a problem hiding this comment.
Would also be good to check that test is not None on line 253.
test_model:
# constraints:
# unique:
# - some_field
drewbanin
approved these changes
Mar 14, 2017
|
@drewbanin I added some more edge case tests and put in the fixes. See what I did for test==None, I don't fully understand your suggestion but I think |
|
lgtm |
added 2 commits
March 14, 2017 21:20
…bug/ignore-commented-schema-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #328