Fix macro depends_on recursion error when macros call themselves (dbt…utils.datediff) #3454
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
adapter_dispatch_infinite_recursion
branch
from
5185823
to
99625c1
Compare
jtcohen6
approved these changes
Jun 11, 2021
gshank
force-pushed
the
adapter_dispatch_infinite_recursion
branch
from
99625c1
to
af0fe12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3444
Description
The dbt_utils postgres datediff macro calls back to the base dbt_utils datediff macro. This caused infinite recursion in the code that gathers up all of the dependent macros for tests. To fix it we check to see if a macro has already been added to the list of dependent macros and skip it.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.